FF152 MediaCapabilities.decodingInfo/encodingInfo() - config.type.webrtc option#29739
FF152 MediaCapabilities.decodingInfo/encodingInfo() - config.type.webrtc option#29739hamishwillee wants to merge 5 commits into
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
| "firefox": { | ||
| "version_added": "63", | ||
| "notes": [ | ||
| "The `webrtc` value of the `type` option is named `transmission`.", |
There was a problem hiding this comment.
This must have been wrong originally. If you look at https://hg-edge.mozilla.org/mozilla-central/rev/95e6d0dc0f14 you can see this change
enum MediaDecodingType {
"file",
"media-source",
+ "webrtc",
};
enum MediaEncodingType {
"record",
- "transmission"
+ "webrtc",
};So the encoding type had the transmission option, and the decoding type did not. That is the opposite of here. I've removed it from decoding below in 3b7ccfa
3eb8c5e to
ea86bfa
Compare
|
To understand this PR, is the following the desired nesting? MediaCapabilities:
|
Is this the rule? I think you have more recent experience with nested data structures. Would like to hear your thoughts. |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
ea86bfa to
a7b62fd
Compare
…alues Use fetch API convention: configuration_parameter as parent, sub-properties as plain names with "property" descriptions nested inside it, and _option suffix for enum values of the type property.
Flatten structure per HTMLCanvasElement convention: all subfeatures are siblings under the method using fully-qualified paramname_prop_parameter keys, with enum values as paramname_prop_parameter_value.
a7b62fd to
805c65c
Compare
|
Thanks @Elchi3.
I used to do the schema defined way, but have been told recently (and asked to modify my PRs) to support a nested form. I recalled "option" being used for enumerated values but I can't find evidence of that. We this needs to be discussed in the BCD meeting to confirm the schema and naming convention to use and then I can match it. My preference is nested "FWIW" - it just feels cleaner and more logical - provided the rendering in MDN works adequately. If that happens ideally I can just drop the last commit. |
FF152 adds support for the
configuration.type.webrtcoption to be passed toMediaCapabilities.decodingInfo()andMediaCapabilities.encodingInfo(), and removes the non-standard "alias"transmissionthat has been around since FF63ish. The addition is behind the flagmedia.mediacapabilities.webrtc.enabled. Bug is https://bugzilla.mozilla.org/show_bug.cgi?id=1825286To do this I have created a structure of nested features to mirror the
configurationoption, which hastypeproperty, and below that has the newwebrtcandtransmission(to be removed when this is merged). Also moved an existing key below that configuraiton option.Related docs work can be tracked in mdn/content#44174